Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequencers): sort sequencers by bond when rotating #724

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 24, 2024

when rotating sequencer, choose the next one sorted by bond

Description


Closes #716

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin linked an issue Mar 24, 2024 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as ready for review March 24, 2024 13:06
@mtsitrin mtsitrin requested a review from a team as a code owner March 24, 2024 13:06
@mtsitrin mtsitrin self-assigned this Mar 24, 2024
@omritoptix
Copy link
Contributor

@mtsitrin test failed

@omritoptix omritoptix changed the title feat: sort sequencers by bond when rotating feat(sequencers): sort sequencers by bond when rotating Mar 25, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.64%. Comparing base (3a4313f) to head (fb95a45).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   30.65%   30.64%   -0.02%     
==========================================
  Files         233      233              
  Lines       32591    32580      -11     
==========================================
- Hits         9991     9984       -7     
+ Misses      21034    21031       -3     
+ Partials     1566     1565       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin merged commit 3b4b731 into main Mar 26, 2024
25 of 26 checks passed
@mtsitrin mtsitrin deleted the 716-make-rotating-sequencer-sorted-by-bond branch March 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make rotating sequencer sorted by bond
3 participants