fix(rollapp): missing rollappid validation on rollapp creation

[mtsitrin]

Description

---

Closes #710

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Targeted PR against the correct branch
• included the correct type prefix in the PR title
• Linked to the GitHub issue with discussion and accepted design
• Targets only one GitHub issue
• Wrote unit and integration tests
• Wrote relevant migration scripts if necessary
• All CI checks have passed
• Added relevant godoc comments
• Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
• Add an issue in the e2e-tests repo if necessary

SDK Checklist

• Import/Export Genesis
• Registered Invariants
• Registered Events
• Updated openapi.yaml
• No usage of go map
• No usage of time.Now()
• Used fixed point arithmetic and not float arithmetic
• Avoid panicking in Begin/End block as much as possible
• No unexpected math Overflow
• Used sendCoin and not SendCoins
• Out-of-block compute is bounded
• No serialized ID at the end of store keys
• UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

• Confirmed the correct type prefix in the PR title
• Reviewers assigned
• Confirmed all author checklist items have been addressed

---;

After reviewer approval:

• In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
• In case the PR targets a release branch, PR must be rebased.

[codecov]

Codecov Report

Attention: Patch coverage is 97.53086% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.72%. Comparing base (5890b2c) to head (e7087fb).
Report is 1 commits behind head on main.

Files	Patch %	Lines
x/rollapp/keeper/msg_server_create_rollapp.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   30.64%   30.72%   +0.07%     
==========================================
  Files         233      234       +1     
  Lines       32580    32603      +23     
==========================================
+ Hits         9984    10017      +33     
+ Misses      21031    21022       -9     
+ Partials     1565     1564       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danwt]

There's a decent amount of duping here

dymension/x/rollapp/keeper/msg_server_create_rollapp.go

Lines 33 to 49 in 7427c40

	// Build the genesis state from the genesis accounts
	var rollappGenesisState *types.RollappGenesisState
	if len(msg.GenesisAccounts) > 0 {
	rollappGenesisState = &types.RollappGenesisState{
	GenesisAccounts: msg.GenesisAccounts,
	IsGenesisEvent: false,
	}
	}
	// copy TokenMetadata
	metadata := make([]*types.TokenMetadata, len(msg.Metadatas))
	for i := range msg.Metadatas {
	metadata[i] = &msg.Metadatas[i]
	}
	// Create an updated rollapp record
	rollapp := types.NewRollapp(msg.Creator, msg.RollappId, msg.MaxSequencers, msg.PermissionedAddresses, metadata, rollappGenesisState)

dymension/x/rollapp/types/message_create_rollapp.go

Lines 48 to 63 in 76dc37a

	// Build the genesis state from the genesis accounts
	var rollappGenesisState *RollappGenesisState
	if len(msg.GenesisAccounts) > 0 {
	rollappGenesisState = &RollappGenesisState{
	GenesisAccounts: msg.GenesisAccounts,
	IsGenesisEvent: false,
	}
	}
	// copy TokenMetadata
	metadata := make([]*TokenMetadata, len(msg.Metadatas))
	for i := range msg.Metadatas {
	metadata[i] = &msg.Metadatas[i]
	}
	rollapp := NewRollapp(msg.Creator, msg.RollappId, msg.MaxSequencers, msg.PermissionedAddresses, metadata, rollappGenesisState)

It's not the end of the world but might be good to cleanup

[danwt]

gj

[zale144]

if genesis state remains nil I think we would get an error in the genesis event later on:
https://github.com/dymensionxyz/dymension/blob/main/x/rollapp/keeper/keeper.go#L68
Not sure if that's expected, if not, we should instantiate rollappGenesisState regardless of genesis accounts being empty or not.
Unless it's expected that for some reason we enforce genesis accounts not being empty. In that case, we should probably fail on validation or something.