-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: accept rollapp initial state with arbitrary height #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsitrin
force-pushed
the
681-support-rollapps-with-initialheight-1
branch
from
March 20, 2024 10:42
2107e1c
to
a721ca7
Compare
mtsitrin
force-pushed
the
681-support-rollapps-with-initialheight-1
branch
from
March 20, 2024 11:44
4dfef5d
to
572c298
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 30.37% 30.63% +0.25%
==========================================
Files 233 233
Lines 32579 32585 +6
==========================================
+ Hits 9897 9982 +85
+ Misses 21127 21036 -91
- Partials 1555 1567 +12 ☔ View full report in Codecov by Sentry. |
omritoptix
previously approved these changes
Mar 20, 2024
Co-authored-by: Omri <[email protected]>
omritoptix
approved these changes
Mar 21, 2024
danwt
approved these changes
Mar 22, 2024
srene
approved these changes
Mar 22, 2024
zale144
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
omritoptix
assigned mtsitrin, omritoptix and srene and unassigned omritoptix, srene and mtsitrin
Mar 23, 2024
srene
pushed a commit
that referenced
this pull request
Mar 25, 2024
Co-authored-by: Omri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #681
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: