Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept rollapp initial state with arbitrary height #687

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 18, 2024

Description


Closes #681

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin linked an issue Mar 18, 2024 that may be closed by this pull request
@mtsitrin mtsitrin force-pushed the 681-support-rollapps-with-initialheight-1 branch from 2107e1c to a721ca7 Compare March 20, 2024 10:42
@mtsitrin mtsitrin force-pushed the 681-support-rollapps-with-initialheight-1 branch from 4dfef5d to 572c298 Compare March 20, 2024 11:44
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.63%. Comparing base (657138c) to head (92e163a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
+ Coverage   30.37%   30.63%   +0.25%     
==========================================
  Files         233      233              
  Lines       32579    32585       +6     
==========================================
+ Hits         9897     9982      +85     
+ Misses      21127    21036      -91     
- Partials     1555     1567      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin marked this pull request as ready for review March 20, 2024 12:29
@mtsitrin mtsitrin requested a review from a team as a code owner March 20, 2024 12:29
omritoptix
omritoptix previously approved these changes Mar 20, 2024
x/rollapp/keeper/msg_server_update_state.go Outdated Show resolved Hide resolved
Co-authored-by: Omri <[email protected]>
Copy link
Contributor

@zale144 zale144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@omritoptix omritoptix merged commit ba6659a into main Mar 23, 2024
13 of 15 checks passed
@omritoptix omritoptix deleted the 681-support-rollapps-with-initialheight-1 branch March 23, 2024 21:39
srene pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support rollapps with initialHeight > 1
5 participants