-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: version bumps #677
fix: version bumps #677
Conversation
Oops, looks like I probably forgot to tidy here |
@faddat the go version in the go.mod is not specified correclty. |
ah thank you! I'll fix that now. |
Ah, I see it now. I'd intended to upgrade golang, but forgot to upgrade it in the ci config files. |
this seems to be the underlying issue: I'll either dial back golang or find a workaround with x/exp |
So, the latest version of comet in this release series (v0.34.32) has an issue compiling with dymension, I guess due to conflicting versions of the exp package vs those used in other dependencies. I will raise an issue upstream on this, but strongly prefer that we get v0.34.32 into this release due to the notes for the release: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 30.69% 30.20% -0.49%
==========================================
Files 227 233 +6
Lines 32052 32565 +513
==========================================
Hits 9837 9837
- Misses 20653 21166 +513
Partials 1562 1562 ☔ View full report in Codecov by Sentry. |
Description
This PR upgrades:
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: