Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version bumps #677

Merged
merged 13 commits into from
Mar 19, 2024
Merged

fix: version bumps #677

merged 13 commits into from
Mar 19, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Mar 16, 2024

Description

This PR upgrades:

  • cosmos-sdk to v0.46.16
  • cometbft-db to v0.11.0
  • go to v1.22.1
  • cosmossdk.io/math to v1.3.0
  • cosmossdk.io/errors to v1.0.1

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@faddat faddat requested a review from a team as a code owner March 16, 2024 15:16
@faddat
Copy link
Contributor Author

faddat commented Mar 17, 2024

Oops, looks like I probably forgot to tidy here

@omritoptix
Copy link
Contributor

@faddat the go version in the go.mod is not specified correclty.

@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2024

ah thank you! I'll fix that now.

@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2024

Ah, I see it now. I'd intended to upgrade golang, but forgot to upgrade it in the ci config files.

@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2024

this seems to be the underlying issue:

I'll either dial back golang or find a workaround with x/exp

@faddat
Copy link
Contributor Author

faddat commented Mar 18, 2024

So, the latest version of comet in this release series (v0.34.32) has an issue compiling with dymension, I guess due to conflicting versions of the exp package vs those used in other dependencies. I will raise an issue upstream on this, but strongly prefer that we get v0.34.32 into this release due to the notes for the release:

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.20%. Comparing base (9a27004) to head (5de5d6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   30.69%   30.20%   -0.49%     
==========================================
  Files         227      233       +6     
  Lines       32052    32565     +513     
==========================================
  Hits         9837     9837              
- Misses      20653    21166     +513     
  Partials     1562     1562              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@faddat faddat mentioned this pull request Mar 18, 2024
29 tasks
mtsitrin
mtsitrin previously approved these changes Mar 18, 2024
@mtsitrin mtsitrin merged commit 23c9237 into dymensionxyz:main Mar 19, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants