Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollapp): rollapp genesis token not registered as IBC denom #673

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

zale144
Copy link
Contributor

@zale144 zale144 commented Mar 15, 2024

Description


Closes #671

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@zale144 zale144 self-assigned this Mar 15, 2024
@zale144 zale144 requested a review from a team as a code owner March 15, 2024 16:08
@omritoptix omritoptix changed the title Zale144/671 fix genesis token ibc denom fix: rollapp genesis token not registered as IBC denom Mar 15, 2024
@omritoptix omritoptix changed the title fix: rollapp genesis token not registered as IBC denom fix(rollapp): rollapp genesis token not registered as IBC denom Mar 15, 2024
@zale144 zale144 force-pushed the zale144/671-fix-genesis-token-ibc-denom branch from 2cf2464 to d25f77e Compare March 15, 2024 16:28
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.89%. Comparing base (9c77e99) to head (d25f77e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   29.87%   29.89%   +0.01%     
==========================================
  Files         225      225              
  Lines       31861    31870       +9     
==========================================
+ Hits         9517     9526       +9     
  Misses      20855    20855              
  Partials     1489     1489              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit 6c97620 into main Mar 15, 2024
6 of 11 checks passed
@omritoptix omritoptix deleted the zale144/671-fix-genesis-token-ibc-denom branch March 15, 2024 16:35
@@ -111,3 +111,6 @@ dymd add-genesis-account "$(dymd keys show "$KEY_NAME" -a --keyring-backend test
dymd gentx "$KEY_NAME" "$STAKING_AMOUNT" --chain-id "$CHAIN_ID" --keyring-backend test
dymd collect-gentxs

set_authorised_deployer_account "$(dymd keys show "$KEY_NAME" -a --keyring-backend test)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zale144 this line breaks the flows of local rollapp setup
either remove here, or adjust the rollapps repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollapp genesis token on the hub don't register the IBC Denom
3 participants