Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation on demand order id max length #656

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Mar 12, 2024

Description


Closes #644

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@omritoptix omritoptix requested a review from a team as a code owner March 12, 2024 21:46
@omritoptix omritoptix linked an issue Mar 12, 2024 that may be closed by this pull request
@omritoptix omritoptix changed the title fix: Added validation on demand order max length in ValidateBasic fix: add validation on demand order max length in ValidateBasic Mar 12, 2024
@omritoptix omritoptix changed the title fix: add validation on demand order max length in ValidateBasic fix: add validation on demand order id max length in ValidateBasic Mar 12, 2024
@omritoptix omritoptix changed the title fix: add validation on demand order id max length in ValidateBasic fix: add validation on demand order id max length Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.83%. Comparing base (9072971) to head (6acf02b).
Report is 1 commits behind head on main.

Files Patch % Lines
x/eibc/types/tx.go 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   29.72%   29.83%   +0.10%     
==========================================
  Files         222      223       +1     
  Lines       31747    31797      +50     
==========================================
+ Hits         9438     9487      +49     
+ Misses      20832    20825       -7     
- Partials     1477     1485       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/eibc/types/tx.go Outdated Show resolved Hide resolved
@omritoptix omritoptix merged commit 4770e99 into main Mar 13, 2024
7 of 12 checks passed
@omritoptix omritoptix deleted the omritoptix/644-fix-eibc-order-id-validation branch March 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit order_id length when submitting eIBC order to avoid block spam
2 participants