Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discard pending rollapp ibc packets upon fraud #653

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 12, 2024

Description


Closes #624

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@omritoptix omritoptix changed the title feat: delayedack middlware should handle fraudsubmitted hooks feat: discard pending rollapp ibc packets upon fraud Mar 12, 2024
@mtsitrin mtsitrin marked this pull request as ready for review March 12, 2024 16:28
@mtsitrin mtsitrin requested a review from a team as a code owner March 12, 2024 16:28
@mtsitrin mtsitrin linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 29.97%. Comparing base (f76fc29) to head (d164d5d).

Files Patch % Lines
x/delayedack/keeper/fraud.go 78.04% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   29.86%   29.97%   +0.10%     
==========================================
  Files         220      221       +1     
  Lines       30812    30855      +43     
==========================================
+ Hits         9202     9248      +46     
+ Misses      20205    20195      -10     
- Partials     1405     1412       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


/* ---------------------------------- utils --------------------------------- */

func generatePackets(rollappId string, num uint64) []commontypes.RollappPacket {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo cleaner to add it to the keeper_test (i.e on the test suite) as a public function.

rollappPacket, err := k.UpdateRollappPacketWithStatus(ctx, rollappPacket, commontypes.Status_REVERTED)
if err != nil {
logger.Error("Error reverting IBC rollapp packet", "rollappID", rollappID, "packetId", packetId, "type", rollappPacket.Type, "error", err.Error())
return err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we'll revert fraud proof on first packet failure. possibly worth wrapping in applyFuncIfNoErr and continue to avoid one packet failing the reversion for all other. especially as the updateRollappPacketWithStatus triggers various hook so doesn't necessarily mean store error. wdyt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought about it quite long.
I just think that the alternative of keeping Pending packets of fraudulent rollapp may cause unexpected behaviour. maybe break invariant

@omritoptix omritoptix merged commit 9a97986 into main Mar 13, 2024
8 of 18 checks passed
@omritoptix omritoptix deleted the mtsitrin/624-delayedack-middlware-should-handle-fraudsubmitted-hooks branch March 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delayedAck middlware should handle FraudSubmitted hooks
2 participants