Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Query demand orders by status cmd #637

Merged

Conversation

hoangdv2429
Copy link
Contributor

Description

This PR will add query demand orders by status to Dymension


Closes #636

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@hoangdv2429 hoangdv2429 requested a review from a team as a code owner March 7, 2024 11:17
Copy link
Contributor

@pgoos pgoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add some tests for this new code?

@omritoptix omritoptix changed the title add Query demand orders by status cmd feat: add Query demand orders by status cmd Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0.45872% with 434 lines in your changes are missing coverage. Please review.

Project coverage is 29.85%. Comparing base (ee0788e) to head (f80c97d).

❗ Current head f80c97d differs from pull request most recent head 28a93d1. Consider uploading reports for the commit 28a93d1 to get more accurate results

Files Patch % Lines
x/eibc/types/query.pb.go 0.64% 307 Missing ⚠️
x/eibc/types/query.pb.gw.go 0.00% 78 Missing and 1 partial ⚠️
x/eibc/keeper/grpc_query.go 0.00% 25 Missing ⚠️
x/eibc/client/cli/query_command_orders.go 0.00% 22 Missing ⚠️
x/eibc/client/cli/query.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   30.29%   29.85%   -0.44%     
==========================================
  Files         210      211       +1     
  Lines       29315    29750     +435     
==========================================
+ Hits         8880     8882       +2     
- Misses      19076    19508     +432     
- Partials     1359     1360       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoangdv2429
Copy link
Contributor Author

@pgoos @omritoptix I added the test, can you have a look now sir 🙏

@pgoos pgoos merged commit bcb9a81 into dymensionxyz:main Mar 7, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to query IBC demand orders by status
2 participants