Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gov proposal for rollapp fraud event #622

Merged
merged 56 commits into from
Mar 5, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Mar 4, 2024

Description


Closes #615

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin linked an issue Mar 4, 2024 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as ready for review March 4, 2024 13:24
@mtsitrin mtsitrin requested a review from a team as a code owner March 4, 2024 13:24
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 4.35484% with 593 lines in your changes are missing coverage. Please review.

Project coverage is 29.87%. Comparing base (d447bab) to head (9754a8a).

Files Patch % Lines
x/rollapp/types/proposal.pb.go 0.67% 439 Missing ⚠️
x/rollapp/keeper/fraud_proposal.go 0.00% 39 Missing ⚠️
x/rollapp/client/cli/tx_submit_fraud_proposal.go 0.00% 34 Missing ⚠️
x/rollapp/types/proposal_submit_fraud.go 5.71% 33 Missing ⚠️
x/sequencer/keeper/hook_listener.go 13.33% 13 Missing ⚠️
x/rollapp/proposal_handler.go 7.69% 11 Missing and 1 partial ⚠️
utils/client_utils.go 0.00% 10 Missing ⚠️
x/rollapp/types/hooks.go 0.00% 6 Missing ⚠️
x/delayedack/hooks.go 0.00% 3 Missing ⚠️
x/streamer/client/cli/tx_create_stream.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   30.43%   29.87%   -0.57%     
==========================================
  Files         201      207       +6     
  Lines       28573    29167     +594     
==========================================
+ Hits         8697     8713      +16     
- Misses      18523    19100     +577     
- Partials     1353     1354       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. you have a typo in the file name you copied from the streamer: x/rollapp/types/proposal_stream.go

x/rollapp/keeper/fraud_proposal.go Outdated Show resolved Hide resolved
@mtsitrin mtsitrin merged commit bd0aa22 into main Mar 5, 2024
5 of 10 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/615-gov-proposal-for-rollapp-fraud-event branch March 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Gov proposal for rollapp fraud event
2 participants