Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to query demand order by id. #608

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Feb 29, 2024

Description


Closes #607

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@omritoptix omritoptix requested a review from a team as a code owner February 29, 2024 11:57
@omritoptix omritoptix linked an issue Feb 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 34.62470% with 270 lines in your changes are missing coverage. Please review.

Project coverage is 31.30%. Comparing base (463c72e) to head (302c0bb).

Files Patch % Lines
x/eibc/types/query.pb.go 39.93% 156 Missing and 29 partials ⚠️
x/eibc/types/query.pb.gw.go 0.00% 78 Missing and 1 partial ⚠️
x/eibc/keeper/grpc_query.go 76.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   30.79%   31.30%   +0.50%     
==========================================
  Files         201      201              
  Lines       28495    28900     +405     
==========================================
+ Hits         8774     9046     +272     
- Misses      18322    18391      +69     
- Partials     1399     1463      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit a2073a5 into main Feb 29, 2024
9 of 10 checks passed
@omritoptix omritoptix deleted the omritoptix/607-query-demand-order-by-id branch February 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to query demand order by id
2 participants