Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable usage of eIBC combined with PFM #601

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Feb 27, 2024

Description


Closes #600

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

---;

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@omritoptix omritoptix requested a review from a team as a code owner February 27, 2024 13:45
@omritoptix omritoptix linked an issue Feb 27, 2024 that may be closed by this pull request
@omritoptix omritoptix changed the title fix: disable usage of eIBC combined with PFM chore: disable usage of eIBC combined with PFM Feb 27, 2024
@omritoptix omritoptix changed the title chore: disable usage of eIBC combined with PFM fix: disable usage of eIBC combined with PFM Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.79%. Comparing base (7575849) to head (8241d43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   30.78%   30.79%           
=======================================
  Files         201      201           
  Lines       28491    28495    +4     
=======================================
+ Hits         8770     8774    +4     
  Misses      18322    18322           
  Partials     1399     1399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit 463c72e into main Feb 28, 2024
9 of 10 checks passed
@omritoptix omritoptix deleted the omritoptix/600-disable-on-recv-packet-pfm-with-eibc branch February 28, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporarily disable eIBC + PFM for txs initiated on rollapp
3 participants