-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support automatic eibc order creation for timeout #598
Conversation
…der upon underlying packet status update.
…levant memo exists.
… ibc packet upon demand order fulfillment.
…t malformed packet attacks.
… and update the error.
…ating demand order with status.
…tix/532-rollapp-packet-deletion
…et is deleted to prevent from breaking invariant.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## omritoptix/532-rollapp-packet-deletion #598 +/- ##
==========================================================================
+ Coverage 30.68% 30.70% +0.01%
==========================================================================
Files 205 205
Lines 28812 28913 +101
==========================================================================
+ Hits 8841 8877 +36
- Misses 18566 18624 +58
- Partials 1405 1412 +7 ☔ View full report in Codecov by Sentry. |
// Create a copy of the packet with the new recipient | ||
// Set the recipient and sender based on the rollapp packet type | ||
recipient, sender := data.Receiver, data.Sender | ||
if rollappPacket.Type == commontypes.RollappPacket_ON_RECV { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe have GetSender()
GetRecepient()
for the rollappPacket
struct
for better readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob is that I need all the other fields also from the data (like denom, amount etc). so I need the data object anyway on the function. however I created a method for getting the transferPacketData
from rollappPacket for better readability.
Co-authored-by: ducnt131 <[email protected]> Co-authored-by: GoodDaisy <[email protected]> Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Description
Closes #593
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
For Reviewer:
---;
After reviewer approval: