Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollapp): validate rollapp token metadata #471

Conversation

VictorTrustyDev
Copy link
Contributor

@VictorTrustyDev VictorTrustyDev commented Jan 4, 2024

Description


RollApp denom metadata will be used to put into x/bank denom metadata thus it should valid token-metadata-convension of x/bank.

Currently implementation does not validate it correctly. This PR aims to fix it.


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@VictorTrustyDev VictorTrustyDev requested a review from a team as a code owner January 4, 2024 16:50
@VictorTrustyDev VictorTrustyDev force-pushed the fix/validate-rollapp-token-metadata branch 2 times, most recently from 38f367d to bd78b68 Compare January 4, 2024 16:55
omritoptix
omritoptix previously approved these changes Jan 12, 2024
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VictorTrustyDev linter issues

@VictorTrustyDev
Copy link
Contributor Author

@omritoptix help me, I don't use lint :)

Btw don't forget the RollApp side

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (248650a) 30.70% compared to head (7e761cb) 30.78%.

Files Patch % Lines
x/rollapp/types/token_metadata.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   30.70%   30.78%   +0.07%     
==========================================
  Files         200      201       +1     
  Lines       28460    28491      +31     
==========================================
+ Hits         8738     8770      +32     
+ Misses      18324    18322       -2     
- Partials     1398     1399       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix dismissed their stale review February 21, 2024 18:25

redundant validation

@VictorTrustyDev VictorTrustyDev force-pushed the fix/validate-rollapp-token-metadata branch from bd78b68 to 7e761cb Compare February 21, 2024 18:40
@VictorTrustyDev
Copy link
Contributor Author

@omritoptix
Done:

  • Rebase
  • Update code follow comment

@omritoptix omritoptix merged commit 4168eb0 into dymensionxyz:main Feb 21, 2024
5 of 7 checks passed
@VictorTrustyDev VictorTrustyDev deleted the fix/validate-rollapp-token-metadata branch February 21, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants