-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rollapp): validate rollapp token metadata #471
fix(rollapp): validate rollapp token metadata #471
Conversation
38f367d
to
bd78b68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VictorTrustyDev linter issues
@omritoptix help me, I don't use lint :) Btw don't forget the RollApp side |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 30.70% 30.78% +0.07%
==========================================
Files 200 201 +1
Lines 28460 28491 +31
==========================================
+ Hits 8738 8770 +32
+ Misses 18324 18322 -2
- Partials 1398 1399 +1 ☔ View full report in Codecov by Sentry. |
…om Metadata from x/bank
bd78b68
to
7e761cb
Compare
@omritoptix
|
Description
RollApp denom metadata will be used to put into
x/bank
denom metadata thus it should valid token-metadata-convension ofx/bank
.Currently implementation does not validate it correctly. This PR aims to fix it.
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsFor Reviewer:
After reviewer approval: