Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register rollapp amino messages to support EIP712 #1229

Conversation

ItzhakBokris
Copy link
Contributor

No description provided.

@ItzhakBokris ItzhakBokris added the enhancement New feature or request label Sep 16, 2024
@ItzhakBokris ItzhakBokris self-assigned this Sep 16, 2024
@ItzhakBokris ItzhakBokris requested a review from a team as a code owner September 16, 2024 12:47
@ItzhakBokris ItzhakBokris linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link
Contributor

@danwt danwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's right Tzachi?

I see maybe some registration is missing like on messages

https://github.com/cosmos/cosmos-sdk/blob/d80078f721428b7482da255f2c62ffb7ccd5beec/x/evidence/types/codec.go#L20

But I'm not sure

@omritoptix omritoptix merged commit f140cd1 into main Sep 16, 2024
96 of 124 checks passed
@omritoptix omritoptix deleted the ItzhakBokris/1228-register-rollapp-amino-messages-to-support-eip712 branch September 16, 2024 13:45
omritoptix pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dym-internal enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Register rollapp amino messages to support EIP712
3 participants