Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example site, popup positioning #25

Merged
merged 24 commits into from
Jul 18, 2022
Merged

New example site, popup positioning #25

merged 24 commits into from
Jul 18, 2022

Conversation

dylandbl
Copy link
Owner

@dylandbl dylandbl commented Jul 16, 2022

Summary

  1. Created a new example site.
  2. Added a new feature to the popup for easy, relative positioning.
  3. Fixed but where "X" close button might be covered by the header.
  4. Added border to popup.

Why this change is needed

  1. If a picture is worth a thousand, an interactive picture must be worth a million.
  2. It was a planned feature, but it ended up becoming core to the layout of the example site and was developed in tandem.
  3. Users would not be able to click the close button.
  4. Creates clear division between the popup and the background.

What was done

  1. Created a lot of new files, reorganised example's App.tsx.
  2. i. Added new prop, placement for positioning of the popup relative to its trigger.
    ii. Moved height and width calculation functions into new file, which also contains placement calculation.
  3. Moved the close button below the header in the DOM.

@dylandbl dylandbl added the work in progress This PR is a work in progress label Jul 16, 2022
@dylandbl dylandbl changed the title New example site New example site, popup positioning Jul 18, 2022
Copy link
Owner Author

@dylandbl dylandbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update package.json version for both RQR and example.

Need to update README with new prop info.

@dylandbl dylandbl merged commit 8f97b15 into main Jul 18, 2022
@dylandbl dylandbl deleted the newExampleSite branch July 18, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress This PR is a work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant