small fixes (#30)

* fix: rqr's onclick Element type should not be optional * style(example): fixed incorrect config div height
dylandbl · Jul 20, 2022 · d42ee32 · d42ee32
1 parent 7d70487
commit d42ee32
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/example/src/components/showcaseComponents/config/ConfigStyles.ts b/example/src/components/showcaseComponents/config/ConfigStyles.ts
@@ -27,7 +27,7 @@ export const InputsContainer = styled.div<{ show: boolean }>`
   ${({ show }) =>
     show
       ? css`
-          height: 150px;
+          height: 176px;
         `
       : css`
           height: 0;

diff --git a/example/src/components/showcaseComponents/gridShowcase/GridShowcase.tsx b/example/src/components/showcaseComponents/gridShowcase/GridShowcase.tsx
@@ -1,7 +1,7 @@
 import { useState } from "react";
 import QuickReactions from "react-quick-reactions";
 import { PlacementType } from "../../../../../lib/esm/types";
-import { commentEmojis } from "../../../utils/sampleData";
+import { gridEmojis } from "../../../utils/sampleData";
 import { Grid, GridItem, EmojiDisplay } from "./GridShowcaseStyles";
 
 export const gridItems: { title: PlacementType | null; show: boolean }[] = [
@@ -140,18 +140,18 @@ export const GridShowcase = () => {
 
   return (
     <>
-      <h2>Try it out</h2>
+      <h2>Try it</h2>
       <Grid>
         {gridItemsArray.map((item, index) => {
           return (
             <QuickReactions
               key={item?.title + index.toString()}
               onClickReaction={(element) => {
-                setCurrentEmoji(element?.textContent);
+                setCurrentEmoji(element.textContent);
               }}
               isVisible={item.show}
               onClose={() => handleVisibility(item.title, false)}
-              reactionsArray={commentEmojis}
+              reactionsArray={gridEmojis}
               placement={item?.title ? item.title : undefined}
               hideHeader
               hideCloseButton

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -31,7 +31,7 @@ export interface RQRProps {
   hideCloseButton?: boolean;
   hideHeader?: boolean;
   isVisible: boolean;
-  onClickReaction: (event?: Element) => void;
+  onClickReaction: (event: Element) => void;
   onClose: () => void;
   outerDivClassName?: string;
   placement?: PlacementType;