Add log_all_output

[mnp]

Use exec to redirect all shell output thereafter.

[dylanaraps]

Are you able to also add a method in the example of undoing the redirection?

[dylanaraps]

LGTM otherwise. 👍

[georgalis]

Hi ! happy to see continued development of this book and the bourne addition too! (BTW, if not already planned, an inventory of bash incompatibilism with bourne would be handy. I've never seen anything that intended to do that...) just a quick comment and observation about this PR, I've seen many failed attempts at sites that wanted to log command line invocations (in addition to output). Different contexts, sometimes shared root logins, but also in scientific environments where it's important to keep an electronic journal of the sequence of commands used. If $TIME $USER@$HOST:$PWD could be recorded along with command line invocations (and parameter expansion, without escape codes for cursor movement etc)---that would be really useful, feature request, with the caveat, I know this would be a very difficult task. also, I noticed FD 6 was used in the last indentation patch, maybe that should be exec 2>&1? Thanks, -George

…

On Sun, Sep 22, 2019 at 10:00 AM black ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In README.md <#84 (comment)> : > @@ -1040,23 +1040,37 @@ printf '' >file ```sh log_all_output() { # Usage: log_all_output log_filename + exec 6>&1 # save stdout Indentation is 4 spaces. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#84?email_source=notifications&email_token=AAE3QC6MQLUSRV5D5XBRGITQK6QCZA5CNFSM4IY6WMT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFQDLBI#pullrequestreview-291517829>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE3QC5MGJUIJIVFYAJ4FB3QK6QCZANCNFSM4IY6WMTQ> .

-- George Georgalis, (415) 894-2710, http://www.galis.org/