Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add default album art for dylanaraps/bum#11 #15

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

Gadgetoid
Copy link
Contributor

We looked into a couple of approaches for supplying default cover art. The simplest seems to be to leverage as much of the existing image handling/caching functionality as possible by supplying the save function with a string of bytes similar to what it would receive from the MusicBrainz API.

Thanks to @Septolum for coming up with an image that scales nicely and compresses well. It's actually a 2-colour PNG, but most image handling libraries don't care if the filename/content type mismatch. (Works for us in PIL, too)

@dylanaraps
Copy link
Owner

This is a really nice solution! 👍

@dylanaraps
Copy link
Owner

Just some very minor lint errors to fix.

@Gadgetoid
Copy link
Contributor Author

On it!

@dylanaraps dylanaraps merged commit 7fdbb98 into dylanaraps:master Sep 30, 2019
@dylanaraps
Copy link
Owner

LGTM 👍

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants