This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add default album art for dylanaraps/bum#11 #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We looked into a couple of approaches for supplying default cover art. The simplest seems to be to leverage as much of the existing image handling/caching functionality as possible by supplying the save function with a string of bytes similar to what it would receive from the MusicBrainz API.
Thanks to @Septolum for coming up with an image that scales nicely and compresses well. It's actually a 2-colour PNG, but most image handling libraries don't care if the filename/content type mismatch. (Works for us in PIL, too)