Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comma separator #39

Merged
merged 7 commits into from
Apr 6, 2020
Merged

comma separator #39

merged 7 commits into from
Apr 6, 2020

Conversation

ieaves
Copy link
Collaborator

@ieaves ieaves commented Mar 21, 2020

New functionality

  • comma separator handling for string digits
  • new utility functionality for working with missing values

Major Proposed Changes

  • Integer should be a strict subset of Float

@ieaves
Copy link
Collaborator Author

ieaves commented Apr 4, 2020

@sbrugman, moved integer as a subset of float.

@ieaves
Copy link
Collaborator Author

ieaves commented Apr 4, 2020

Resolves #18

@sbrugman
Copy link
Contributor

sbrugman commented Apr 6, 2020

The following points may improve the PR:

  • The thousands separator depends on the locale. Thin spaces, periods and comma's are all used to denote groups of thousands. If the separator configurable, then the types can be compatible with all numeric conventions.

  • When the seperator is set to None (default), the type should fall back to it's current (less expensive) behaviour.

…e work.

Merged now:
- Integer should be a strict subset of Float
- Fix pandas future warning
@sbrugman sbrugman merged commit 9e550d0 into master Apr 6, 2020
@sbrugman sbrugman deleted the thousands-sep branch April 6, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants