This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
Allow Smart Contracts to make off-chain loan offerings #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanChou
approved these changes
Feb 7, 2018
| * If true is returned, and no errors are thrown by the ShortSell contract, the loan will have | ||
| * occurred. This means that verifyLoanOffering can also be used to update internal contract | ||
| * state on a loan. | ||
| * |
There was a problem hiding this comment.
Add comments so that people can more easily tell what the function signature is
migrations/2_deploy.js
Outdated
| ONE_DAY | ||
| ); | ||
|
|
||
| // TODO this fails - over gas limit |
There was a problem hiding this comment.
Remove this, right? No longer fails?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #25