Include certificate issuing organization in response #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-ruetz
changed the title
|
Hi @dyaa, just following up on this PR that I made a few months ago. Is there any interest from either yourself/users of ssl-checker in adding certificate issuing organization functionality to this tool? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dyaa - first of all, thank you for creating this excellent tool! I discovered it just yesterday but it's already made my life much easier in terms of managing my SSL certificates.
One feature that I'd appreciate having is the ability to see the certificate issuing organization in the ssl-checker return object. Speaking personally, I have many different cert issuers for my various domains (and I'm sure this experience is quite common). Having easy access to the issuer in the return object could help further simplify the cert management process.
This pull request includes said feature; this is my first time working with TypeScript, so hopefully everything looks OK. Also included in this PR are fixes for the security issues identified by
npm auditas well as updating the dependencies listed bynpm outdated. I also ran the NPMbuild|lint|testscripts to ensure they passed.Thanks!