-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Upgrade #232
Typescript Upgrade #232
Conversation
Note: @storybook/addon-knobs is now deprecated, 6.3.0 is the final version
❌ Deploy Preview for dxos-docs-protocols failed. 🔨 Explore the source changes: de12eb2 🔍 Inspect the deploy log: https://app.netlify.com/sites/dxos-docs-protocols/deploys/60f1593d2f62e60007b948d3 |
@@ -39,16 +39,21 @@ | |||
"@babel/core": "~7.13.15", | |||
"@babel/plugin-transform-runtime": "^7.11.5", | |||
"@dxos/eslint-plugin": "~1.0.10", | |||
"@storybook/addon-knobs": "^6.2.9", | |||
"@storybook/react": "^6.2.9", | |||
"@storybook/addon-knobs": "^6.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is storybook upgrade required for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out it was.
The single story is kept in demos anyway, one less thing to maintain
Note - I removed the |
Background
noImplicitOverride
flag #111Changes
typescript
version to4.3.5
noImplicitOverride
in the roottsconfig.json
override
keywords through the repoNotes
@storybook/addon-knobs
is now deprecated and6.3.0
is the final version, at some point the storybooks will need to be upgrades to use@storybook/addon-controls
which is its successor