Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Upgrade #232

Merged
merged 12 commits into from
Jul 16, 2021
Merged

Typescript Upgrade #232

merged 12 commits into from
Jul 16, 2021

Conversation

wittjosiah
Copy link
Member

Background

Changes

  • Bump typescript version to 4.3.5
  • Enable noImplicitOverride in the root tsconfig.json
  • Add necessary override keywords through the repo
  • Upgrade storybook dependencies to their latest versions

Notes

  • After the typescript upgrade the following issue cropped up during storybook builds TypeError: (tag.text || "").trim is not a function storybookjs/storybook#15067
  • The issue was supposedly fixed in storybooks version 6.3.0, however after upgrade storybooks as well the build issue still seems to be occurring, this will need to be resolved before this can be merged
  • Another note on this is that @storybook/addon-knobs is now deprecated and 6.3.0 is the final version, at some point the storybooks will need to be upgrades to use @storybook/addon-controls which is its successor

Note: @storybook/addon-knobs is now deprecated, 6.3.0 is the final
version
@wittjosiah wittjosiah requested review from rzadp and dmaretskyi July 15, 2021 03:10
@wittjosiah wittjosiah self-assigned this Jul 15, 2021
@netlify
Copy link

netlify bot commented Jul 15, 2021

❌ Deploy Preview for dxos-docs-protocols failed.

🔨 Explore the source changes: de12eb2

🔍 Inspect the deploy log: https://app.netlify.com/sites/dxos-docs-protocols/deploys/60f1593d2f62e60007b948d3

@dmaretskyi dmaretskyi marked this pull request as ready for review July 15, 2021 12:27
@@ -39,16 +39,21 @@
"@babel/core": "~7.13.15",
"@babel/plugin-transform-runtime": "^7.11.5",
"@dxos/eslint-plugin": "~1.0.10",
"@storybook/addon-knobs": "^6.2.9",
"@storybook/react": "^6.2.9",
"@storybook/addon-knobs": "^6.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is storybook upgrade required for this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it was.

@rzadp
Copy link
Contributor

rzadp commented Jul 16, 2021

Note - I removed the react-ux storybook config. One less storybook config to maintain, and also the single story that was there is repeated in demos

@rzadp rzadp merged commit 63c0902 into main Jul 16, 2021
@rzadp rzadp deleted the wittjosiah/typescript-upgrade branch July 16, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typescript to 4.3 and enable noImplicitOverride flag
3 participants