Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yt-dlp from youtube-dl #63

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Switch to yt-dlp from youtube-dl #63

merged 1 commit into from
Mar 18, 2023

Conversation

jmintb
Copy link
Contributor

@jmintb jmintb commented Mar 18, 2023

Addresses: #56

./start_kit/video_downloader.py was not working with some youtube
videos, due to youtube-dl out of date.

Therefore this commit updates ./start_kit/video_downloader.py to use yt-dlp which is
a more up to date fork of youtube-dl.

It looks like youtube-dl is under new maintenance and may become
viable in the future. Therefore the youtube_downloader variable can be
changes in ./start_kit/video_downloader.py to easily switch between the two.

Relevant github issue for youtube-dl status: ytdl-org/youtube-dl#30568

@jmintb
Copy link
Contributor Author

jmintb commented Mar 18, 2023

I have marked this as a draft because I am running ./start_kit/video_downloader.py locally to verify the changes, but it is fine to review.

@jmintb jmintb marked this pull request as ready for review March 18, 2023 10:45
@jmintb
Copy link
Contributor Author

jmintb commented Mar 18, 2023

I have marked this as a draft because I am running ./start_kit/video_downloader.py locally to verify the changes, but it is fine to review.

It seems to work well, I haven't tested all of the videos but it could download youtube videos just fine. 🥳

Start downloading youtube videos.
[youtube] Extracting URL: https://www.youtube.com/watch?v=0UsjUE-TXns
[youtube] 0UsjUE-TXns: Downloading webpage
[youtube] 0UsjUE-TXns: Downloading android player API JSON
[info] 0UsjUE-TXns: Downloading 1 format(s): 18
[download] Destination: raw_videos/0UsjUE-TXns.mp4
[download] 100% of   80.76KiB in 00:00:00 at 157.27KiB/s
Finish downloading youtube video url https://www.youtube.com/watch?v=0UsjUE-TXns
[youtube] Extracting URL: https://www.youtube.com/watch?v=1QOYOZ3g-aY
[youtube] 1QOYOZ3g-aY: Downloading webpage
[youtube] 1QOYOZ3g-aY: Downloading android player API JSON
ERROR: [youtube] 1QOYOZ3g-aY: Video unavailable
Unsuccessful downloading - youtube video url https://www.youtube.com/watch?v=1QOYOZ3g-aY
[youtube] Extracting URL: https://www.youtube.com/watch?v=aGtIHKEdCds
[youtube] aGtIHKEdCds: Downloading webpage
[youtube] aGtIHKEdCds: Downloading android player API JSON
[info] aGtIHKEdCds: Downloading 1 format(s): 22
[download] Destination: raw_videos/aGtIHKEdCds.mp4
[download] 100% of  363.87KiB in 00:00:00 at 768.47KiB/s
Finish downloading youtube video url https://www.youtube.com/watch?v=aGtIHKEdCds

Addresses: dxli94#56

./start_kit/video_downloader.py was not working with some youtube
videos, due to youtube-dl out of date.

Therefore this commit updates ./start_kit/video_downloader.py to use yt-dlp which is
a more up to date fork of youtube-dl.

It looks like youtube-dl is under new maintenance and may become
viable in the future. Therefore the youtube_downloader variable can be
changes in ./start_kit/video_downloader.py to easily switch between the two.

Relevant github issue for youtube-dl status: ytdl-org/youtube-dl#30568
@dxli94
Copy link
Owner

dxli94 commented Mar 18, 2023

@jmintb Thanks for the contribution - very much appreciated.

@jmintb
Copy link
Contributor Author

jmintb commented Mar 18, 2023

@jmintb Thanks for the contribution - very much appreciated.

thanks for the dataset!

@jmintb jmintb mentioned this pull request Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants