This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
feat(pool): Add an option to Pool Configuration for scratch org creation time #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add waitTime as an optional config in pool defintion. This allows the command to wait for longer to create scratch orgs,as scratch orgs often created from shape take a considerable time fix #818
Codecov Report
@@ Coverage Diff @@
## develop #903 +/- ##
===========================================
+ Coverage 80.05% 80.07% +0.01%
===========================================
Files 36 36
Lines 1103 1104 +1
Branches 234 234
===========================================
+ Hits 883 884 +1
Misses 220 220
Continue to review full report at Codecov.
|
azlam-abdulsalam
changed the title
feat/scratchorg creation wait
Add an option to Pool Configuration for scratch org creation time
Mar 23, 2022
Excited about this fix, thanks @azlam-abdulsalam |
aly76
suggested changes
Mar 24, 2022
azlam-abdulsalam
changed the title
Add an option to Pool Configuration for scratch org creation time
feat(poool): Add an option to Pool Configuration for scratch org creation time
Mar 24, 2022
azlam-abdulsalam
changed the title
feat(poool): Add an option to Pool Configuration for scratch org creation time
feat(pool): Add an option to Pool Configuration for scratch org creation time
Mar 24, 2022
…into feat/scratchorg-creation-wait
…centure/sfpowerscripts into feat/scratchorg-creation-wait
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add wait time as an addition parameter in pool config, Fixes #818
Checklist
All items have to be completed before a PR is merged