This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
fix(npm-scope): converts npm scope to lowercase during publish and fetch #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #833 +/- ##
========================================
Coverage 66.22% 66.22%
========================================
Files 46 46
Lines 1593 1593
Branches 342 342
========================================
Hits 1055 1055
Misses 538 538 Continue to review full report at Codecov.
|
aly76
approved these changes
Feb 7, 2022
aly76
suggested changes
Feb 7, 2022
packages/sfpowerscripts-cli/src/impl/artifacts/FetchAnArtifactFromNPM.ts
Outdated
Show resolved
Hide resolved
azlam-abdulsalam
commented
Feb 9, 2022
packages/sfpowerscripts-cli/src/impl/artifacts/FetchAnArtifactFromNPM.ts
Outdated
Show resolved
Hide resolved
…FromNPM.ts Fixed to Use toLowerCase
aly76
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #799: converts npm scope to lowercase during publish and fetch. This ensures issues when a package is published, scope is already converted to lowercase and the package is not found during release/prepare/fetch when the scope is provided in upper/mixedcase