This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
fix(prepare): allow prepare to go ahead when artifacts are not yet published #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…published In some cases, the branch head when prepare gets triggered will be ahead of the CI pipeline, which can result in prepare being failing, as the last validated packages wont be yet available in the artifact repository. This fix is to skip those missing packages and use the sfdx-project.json from the last validatedto create the pools
Codecov Report
@@ Coverage Diff @@
## develop #706 +/- ##
========================================
Coverage 64.18% 64.18%
========================================
Files 43 43
Lines 1438 1438
Branches 250 256 +6
========================================
Hits 923 923
Misses 515 515 Continue to review full report at Codecov.
|
azlam-abdulsalam
changed the title
aly76
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases, when the branch head is ahead with a newly introduced package and CI pipeline run has not completed yet, this will result in prepare failing with unable to fetch artifacts as the artifact is not available yet in the artifact repository.
This fix is to skip those missing packages and use the sfdx-project.json from the last validated set of packages to create the pools