Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Update PMD analysis to add pmd minimumpriority option #658

Closed

Conversation

DanielCalle
Copy link
Contributor

I have added the option of minimumpriority option to PMD analizer. It is really useful to be able to apply the rules that cause an error and those that we can see as warnings without separating in different ruleset.

@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 August 18, 2021 22:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #658 (fb0aa89) into develop (b14f451) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #658   +/-   ##
========================================
  Coverage    64.59%   64.59%           
========================================
  Files           43       43           
  Lines         1429     1429           
  Branches       242      242           
========================================
  Hits           923      923           
  Misses         506      506           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14f451...fb0aa89. Read the comment docs.

@azlam-abdulsalam
Copy link
Contributor

@aly76 Can you check whether this would fix #432

aly76
aly76 previously approved these changes Aug 24, 2021
@aly76 aly76 self-requested a review August 25, 2021 04:04
@azlam-abdulsalam
Copy link
Contributor

@DanielCalle we will be revising this in a different model. We would rather be displaying all errors, and providing an option to determine at what level it should break .

@azlam-abdulsalam azlam-abdulsalam self-requested a review August 25, 2021 04:08
@azlam-abdulsalam
Copy link
Contributor

@DanielCalle We have introduced an alternate in #667

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants