Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Migrate sfpowerscripts artifact to custom setting #545

Merged
merged 11 commits into from
Jun 8, 2021

Conversation

aly76
Copy link
Contributor

@aly76 aly76 commented Jun 6, 2021

Closes Issue #476

  • Replaced SfpowerscriptsArtifact__c with SfpowerscriptsArtifact2__c custom setting
  • Each record takes up 290 bytes in the app layer cache
  • When the custom setting has no records, and the source object has more than one record, records will be migrated to the custom setting
  • Max. number of records that can mgirated is 200, using the tree API

@aly76 aly76 added this to the Milestone 24 milestone Jun 6, 2021
@aly76 aly76 requested a review from azlam-abdulsalam June 6, 2021 23:41
aly76 added 5 commits June 7, 2021 09:50
Prevent the updater or checker from updating sfpowerscripts artifacts if either
of the queries for SfpowerscriptsArtifact__c or SfpowerscriptsArtifact2__c fail
due to reason other than not existing.
@azlam-abdulsalam azlam-abdulsalam linked an issue Jun 7, 2021 that may be closed by this pull request
aly76 added 4 commits June 8, 2021 10:48
Fix missing await on ArtifactMigrator.exec

Fix duplicate migrations
Mock resolved value for ArtifactorMigrator.exec()
@codecov-commenter
Copy link

Codecov Report

Merging #545 (3529185) into develop (f39432d) will decrease coverage by 4.06%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #545      +/-   ##
===========================================
- Coverage    80.01%   75.94%   -4.07%     
===========================================
  Files           38       39       +1     
  Lines         1291     1372      +81     
  Branches       226      248      +22     
===========================================
+ Hits          1033     1042       +9     
- Misses         258      330      +72     
Impacted Files Coverage Δ
packages/core/src/artifacts/ArtifactMigrator.ts 7.69% <7.69%> (ø)
...src/artifacts/ArtifactInstallationStatusUpdater.ts 100.00% <100.00%> (ø)
...es/core/src/artifacts/InstalledAritfactsFetcher.ts 94.44% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bcb861...3529185. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam merged commit 45d7c03 into develop Jun 8, 2021
@azlam-abdulsalam azlam-abdulsalam deleted the sfpowerscripts-artifact-custom-setting branch June 8, 2021 04:53
@azlam-abdulsalam azlam-abdulsalam removed this from the Milestone 24 milestone Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate sfpowerscripts artifact record to use custom settings
3 participants