Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Show name and context on package validation fail #525

Merged

Conversation

LawrenceLoz
Copy link
Contributor

Including further context on package version validation failure

It's useful to know which package caused this, and to suggest the user checks package directory if they're expecting package to be built as Unlocked (may not be clear that a package without type attribute which isn't added to packageAliases will be treated as a Source package)

Also added jest tests for this function

@azlam-abdulsalam azlam-abdulsalam requested a review from aly76 May 21, 2021 23:44
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label May 21, 2021
@azlam-abdulsalam azlam-abdulsalam added this to the Milestone 23 milestone May 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #525 (44c3f88) into develop (83f33cf) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #525      +/-   ##
===========================================
+ Coverage    79.39%   80.01%   +0.61%     
===========================================
  Files           38       38              
  Lines         1291     1291              
  Branches       222      226       +4     
===========================================
+ Hits          1025     1033       +8     
+ Misses         266      258       -8     
Impacted Files Coverage Δ
packages/core/src/utils/Delay.ts 100.00% <100.00%> (ø)
...ckages/sfpowerscripts-cli/src/ProjectValidation.ts 100.00% <100.00%> (+30.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25db638...44c3f88. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants