Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

All package types must be promoted to be deployed to production #438

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

aly76
Copy link
Contributor

@aly76 aly76 commented Mar 15, 2021

Breaking change: affects deployment of existing artifacts to prod

  • All packages must now be promoted to be deployed to production, when using the orchestrator
  • Fix getOrgDetails interface

This change is a preventative measure to avoid deploying non-release candidates to production.

All packages must now be promoted to be deployed to production, when using the
orchestrator
@codecov-io
Copy link

Codecov Report

Merging #438 (c9718b6) into develop (0eab30d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #438   +/-   ##
========================================
  Coverage    80.72%   80.72%           
========================================
  Files           32       32           
  Lines         1110     1110           
  Branches       197      197           
========================================
  Hits           896      896           
  Misses         214      214           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd4629...c9718b6. Read the comment docs.

@azlam-abdulsalam
Copy link
Contributor

@aly76 can we add a temporary hidden flag 'allowNonPromotedPackages' to ease during transition phase, as there would be many packages that wont have the isPromotedFlag

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@azlam-abdulsalam azlam-abdulsalam merged commit 6a7ff59 into develop Mar 16, 2021
@azlam-abdulsalam azlam-abdulsalam deleted the promote-source-packages branch March 16, 2021 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail early during deployment to production if using non promoted packages
3 participants