Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(schema): update schema to remove warning around seedMetadata #1400

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Sep 1, 2023

Adds seedMetadata to the supported feature list

fixes #1349

Summary generated by Reviewpad on 01 Sep 23 04:16 UTC

This pull request updates the schema to remove a warning related to "seedMetadata". It adds "seedMetadata" to the supported feature list. This patch includes 127 insertions and 49 deletions in the sfdx-project.schema.json file. The change fixes issue #1349.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Adds seedMetadata to the supported feature list

fixes #1349
@reviewpad reviewpad bot requested a review from zhebinliu September 1, 2023 04:15
@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ecad97) 46.91% compared to head (ecf6c13) 46.91%.

❗ Current head ecf6c13 differs from pull request most recent head eebe718. Consider uploading reports for the commit eebe718 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files          70       70           
  Lines        2656     2656           
  Branches      309      309           
=======================================
  Hits         1246     1246           
  Misses       1408     1408           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azlam-abdulsalam azlam-abdulsalam merged commit f686074 into main Sep 3, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the 1349-orchestratorprepare-warning-about-invalid-property-seedmetadata branch September 3, 2023 22:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orchestrator:prepare warning about invalid property "seedMetadata"
2 participants