Update regex for clientId

[rygramer-usds]

Summary generated by Reviewpad on 28 Aug 23 20:56 UTC

This pull request updates the regex pattern for the clientId in the IsValidSfdxAuthUrl.ts file. The new pattern includes alphanumeric characters, periods, underscores, and equal signs.

When using a custom Connected App (and not the standard Salesforce CLI Connected App), this regex expression returns a false negative as the Client Id (ie Consumer Keys) of custom connected apps can have:

• numbers
• _
• .
• (I didn't actually observe =, but adding it in there just in case.)

Checklist

All items have to be completed before a PR is merged

• Adhere to Contribution Guidelines
• Updates to Decision Records considered?
• Updates to documentation at DX@Scale Guide considered?
• Tested changes?
• Unit Tests new and existing passing locally?

[reviewpad]

Thank you @rygramer-usds for this first contribution!

[reviewpad]

Reviewpad Report

‼️ Errors

• Unconventional commit detected: 'Update regex for clientId' (7f1b650)
• Unconventional title detected: 'Update regex for clientId' illegal 'U' character in commit message type: col=00

⚠️ Warnings

• Please link an issue to the pull request

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e5f12a) 46.91% compared to head (b5ddaf8) 46.91%.

❗ Current head b5ddaf8 differs from pull request most recent head 7f1b650. Consider uploading reports for the commit 7f1b650 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1394   +/-   ##
=======================================
  Coverage   46.91%   46.91%           
=======================================
  Files          70       70           
  Lines        2656     2656           
  Branches      309      309           
=======================================
  Hits         1246     1246           
  Misses       1408     1408           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.