This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
fix(docker): remove high uid in docker image and migrate to sf CLI v2 #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This docker file uses the official node image instead of the sfdx image. This should fix the issue with high uid encountered in some CI/CD setups. SFDX and SF v1 have been replaced with SF v2.
|
Thank you @rody for this first contribution! |
|
Reviewpad Report
This docker file uses the official node image instead of the sfdx
|
rody
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 46.91% 46.91%
=======================================
Files 70 70
Lines 2656 2656
Branches 309 309
=======================================
Hits 1246 1246
Misses 1381 1381
Partials 29 29 ☔ View full report in Codecov by Sentry. |
azlam-abdulsalam
added a commit
that referenced
this pull request
Aug 11, 2023
…#1380) remove high uid in docker image and migrate to sf CLI v2 This docker file uses the official node image instead of the sfdx image. This should fix the issue with high uid encountered in some CI/CD setups. SFDX and SF v1 have been replaced with SF v2. Co-authored-by: Azlam <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This docker file uses the official node image instead of the sfdx image. This should fix the issue with high uid encountered in some CI/CD setups.
SFDX and SF v1 have been replaced with SF v2.
fix #1307
Summary generated by Reviewpad on 09 Aug 23 06:07 UTC
This pull request removes the high uid issue in the docker image and migrates to the sf CLI version 2. It replaces the use of SFDX and SF v1 with SF v2. The changes include switching from the salesforce/salesforcedx image to the node:18-bookworm image, updating dependencies, and installing the necessary packages. Additionally, the labels, environment variables, and entrypoint are modified.
Checklist
All items have to be completed before a PR is merged