Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(triggerApexTests): second test run results are not merged #1360

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix(triggerApexTests): second test run results are not merged #1360

merged 2 commits into from
Jul 20, 2023

Conversation

Schuchie
Copy link
Contributor

@Schuchie Schuchie commented Jul 18, 2023

Summary generated by Reviewpad on 18 Jul 23 15:16 UTC

This pull request fixes the issue where the results of the second test run were not merged with the original test results. The patch modifies the TriggerApexTests.ts file by adding logic to merge the test results and code coverage results from the second run with the original results. The code uses loops and conditional statements to iterate through the test results and code coverage results, and update or append them to the original results accordingly. Finally, the patch recalculates the math based on the updated results.

fixes #1359

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@reviewpad reviewpad bot requested a review from azlam-abdulsalam July 18, 2023 15:16
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 18, 2023
@Schuchie Schuchie closed this Jul 18, 2023
@Schuchie Schuchie reopened this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (19af0fd) 47.03% compared to head (8035879) 47.03%.

❗ Current head 8035879 differs from pull request most recent head 62f43ab. Consider uploading reports for the commit 62f43ab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   47.03%   47.03%           
=======================================
  Files          70       70           
  Lines        3098     3098           
  Branches      659      659           
=======================================
  Hits         1457     1457           
  Misses       1616     1616           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Schuchie
Copy link
Contributor Author

Hey @azlam-abdulsalam,
I did not added tests for the fix. The whole class is currently not tested. I think the only way to test this class would be with mocked classes.

@Schuchie Schuchie changed the title fix(TriggerApexTests): second test run results are not merged fix(triggerApexTests): second test run results are not merged Jul 18, 2023
@azlam-abdulsalam azlam-abdulsalam added this to the July 23 milestone Jul 20, 2023
@reviewpad
Copy link

reviewpad bot commented Jul 20, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Remove console logs' (62f43ab)

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Schuchie

@azlam-abdulsalam azlam-abdulsalam merged commit 28e20e6 into dxatscale:main Jul 20, 2023
@azlam-abdulsalam azlam-abdulsalam added bug Something isn't working and removed small Pull request is small waiting-for-review labels Aug 10, 2023
@reviewpad reviewpad bot added the small Pull request is small label Aug 10, 2023
azlam-abdulsalam pushed a commit that referenced this pull request Aug 11, 2023
* fix(TriggerApexTests): second test run results are not merged

* Remove console logs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sfp orchestrator:validate with Code Coverage Validation
2 participants