Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Initialise CLI commands by loading sfpowerscripts variables from the environment #136

Merged
merged 11 commits into from
Aug 31, 2020
Merged

Initialise CLI commands by loading sfpowerscripts variables from the environment #136

merged 11 commits into from
Aug 31, 2020

Conversation

aly76
Copy link
Contributor

@aly76 aly76 commented Aug 29, 2020 •
edited
Loading

Fixes #133

  • CLI commands extend SfpowerscriptsCommand, which contains member function for initialising Sfdx flags with sfpowerscripts environment variables.
  • SfpowerscriptsCommand implements SfdxCommand.run() as a common entrypoint for all commands, and declares an abstract method Sfpowerscripts_run() to be implemented by commands
  • Initialise CLI commands by loading sfpowerscripts variables from environment, if the input matches one of the variable names defined in the sfpowerscripts variable dictionary
  • Update README.md with recommended way of using output variables
  • Decrease indentation in deploy source

@aly76 aly76 added the enhancement enhancement to existing feature label Aug 29, 2020
@aly76 aly76 added this to the Milestone 17 milestone Aug 29, 2020
@aly76 aly76 changed the title Load sfpowerscripts variables Initialise CLI commands by loading sfpowerscripts variables from the environment Aug 29, 2020
@aly76 aly76 requested a review from azlam-abdulsalam August 29, 2020 08:32
azlam-abdulsalam
azlam-abdulsalam previously approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie

@azlam-abdulsalam azlam-abdulsalam self-requested a review August 31, 2020 00:20
azlam-abdulsalam
azlam-abdulsalam approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

@azlam-abdulsalam azlam-abdulsalam merged commit 85f700e into develop Aug 31, 2020
@azlam-abdulsalam azlam-abdulsalam deleted the feature/load-env-var branch August 31, 2020 03:58
@azlam-abdulsalam azlam-abdulsalam removed this from the Milestone 17 milestone Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@azlam-abdulsalam azlam-abdulsalam azlam-abdulsalam approved these changes

Assignees
No one assigned
Labels
enhancement enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify CLI usage by deprecating readvars
2 participants
@aly76 @azlam-abdulsalam