Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(fht): rollbackOnError need to be true for production #1299

Conversation

azlam-abdulsalam
Copy link
Contributor

Rollback on error need to be set to true for production deployments. This was inadvertenly skipped
in testing and never picked up in the last release

fix #1298

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Rollback on error need to be set to true for production deployments. This was inadvertenly skipped
in testing and never picked up in the last release

fix #1298
@azlam-abdulsalam azlam-abdulsalam linked an issue Apr 24, 2023 that may be closed by this pull request
@reviewpad
Copy link

reviewpad bot commented Apr 24, 2023

AI-Generated Summary: This pull request contains a fix for the rollbackOnError field, which now needs to be set to true for production deployments. The change is applied to both the FHTEnabler.ts and FTEnabler.ts files, ensuring that any errors will cause a rollback in the deployment process. This was an issue that was not previously detected in testing, and the patch addresses it accordingly.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 24, 2023
Copy link
Contributor

@vuha-acn vuha-acn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reviewpad reviewpad bot requested a review from gnemiq April 24, 2023 23:39
@azlam-abdulsalam azlam-abdulsalam merged commit 89b600e into main Apr 24, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the 1298-field-history-tracking-enabler-skipped-due-to-error branch April 24, 2023 23:40
@azlam-abdulsalam azlam-abdulsalam added this to the Release - April 2023 milestone May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field History Tracking Enabler skipped due to error
2 participants