Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(validate): aliasified packages are ignored in validate #1293

Conversation

azlam-abdulsalam
Copy link
Contributor

BREAKING CHANGE: validate command will now respect aliasified
[packages. This means aliasified packages which do not have
a default directory will fail during validation. To fix this,
either ignore the package or add a default directory to the
aliasified package which is the contents that you want
to deploy to the scratch origin

fixes #1289

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

BREAKING CHANGE: validate command will now respect aliasified
[packages. This means aliasified packages which do not have
a default directory will fail during validation. To fix this,
either ignore the package or add a default directory to the
aliasified package which is the contents that you want
to deploy to the scratch origin

fixes #1289]
@reviewpad
Copy link

reviewpad bot commented Apr 19, 2023

AI-Generated Summary: This pull request includes a fix for the issue where aliasified packages are ignored during the validation process. The update ensures that the validate command now respects aliasified packages and handles cases where packages do not have a default directory. This change is considered a breaking change and may require adjustments to any affected packages to either ignore them or add a default directory. The patch modifies the BuildImpl.ts file, specifically updating the filtering logic for aliasified packages. The associated issue is #1289.

@reviewpad reviewpad bot requested a review from zhebinliu April 19, 2023 13:16
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Apr 19, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 19, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'fix(validate): aliasified packages are ignored in validate

BREAKING CHANGE: validate command will now respect aliasified
[packages. This means aliasified packages which do not have
a default directory will fail during validation. To fix this,
either ignore the package or add a default directory to the
aliasified package which is the contents that you want
to deploy to the scratch origin

fixes #1289]' (e4c3611)

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a472e05) 61.17% compared to head (cf0cfa8) 61.17%.

❗ Current head cf0cfa8 differs from pull request most recent head e4c3611. Consider uploading reports for the commit e4c3611 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   61.17%   61.17%           
=======================================
  Files          61       61           
  Lines        2117     2117           
  Branches      443      443           
=======================================
  Hits         1295     1295           
  Misses        770      770           
  Partials       52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vuha-acn vuha-acn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@azlam-abdulsalam azlam-abdulsalam merged commit 3bcf94a into main Apr 24, 2023
@azlam-abdulsalam azlam-abdulsalam deleted the 1289-aliasfied-packages-are-ignored-in-validate-with-release-config branch April 24, 2023 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aliasfied packages are ignored in Validate with Release Config
2 participants