Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(publish): Add new flag to delete Git tags by age and limit minim… #1275

Merged

Conversation

JoeffreyChaucer
Copy link
Contributor

@JoeffreyChaucer JoeffreyChaucer commented Mar 21, 2023

…um tags to keep

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@JoeffreyChaucer JoeffreyChaucer force-pushed the feat/add-new-flag-delete-tag branch from 5ed4701 to 6736263 Compare March 21, 2023 04:04
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.94 ⚠️

Comparison is base (d1c0fff) 62.11% compared to head (46bf8df) 61.17%.

❗ Current head 46bf8df differs from pull request most recent head 844a62b. Consider uploading reports for the commit 844a62b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
- Coverage   62.11%   61.17%   -0.94%     
==========================================
  Files          61       61              
  Lines        2085     2117      +32     
  Branches      429      434       +5     
==========================================
  Hits         1295     1295              
- Misses        790      822      +32     
Impacted Files Coverage Δ
packages/core/src/git/GitTags.ts 26.47% <0.00%> (-23.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JoeffreyChaucer JoeffreyChaucer marked this pull request as ready for review March 21, 2023 08:56
@JoeffreyChaucer JoeffreyChaucer marked this pull request as draft March 21, 2023 08:57
@azlam-abdulsalam azlam-abdulsalam marked this pull request as ready for review March 21, 2023 09:08
@azlam-abdulsalam azlam-abdulsalam marked this pull request as draft March 21, 2023 23:48
@JoeffreyChaucer JoeffreyChaucer force-pushed the feat/add-new-flag-delete-tag branch from 94aab75 to de8046f Compare March 22, 2023 00:12
@azlam-abdulsalam azlam-abdulsalam self-requested a review March 22, 2023 01:16
@azlam-abdulsalam azlam-abdulsalam marked this pull request as ready for review March 22, 2023 01:16
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JoeffreyChaucer for the PR

@azlam-abdulsalam azlam-abdulsalam self-requested a review March 22, 2023 01:25
@azlam-abdulsalam azlam-abdulsalam merged commit aae62d6 into dxatscale:main Mar 22, 2023
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label Mar 30, 2023
@azlam-abdulsalam azlam-abdulsalam added this to the Release - March 2023 milestone Mar 30, 2023
@reviewpad reviewpad bot requested a review from azlam-abdulsalam March 30, 2023 03:32
@reviewpad reviewpad bot added the medium Pull request is medium label Mar 30, 2023
@reviewpad
Copy link

reviewpad bot commented Mar 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants