Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Resolve dependencies for Build #1019

Merged
merged 16 commits into from
Jun 15, 2022
Merged

Resolve dependencies for Build #1019

merged 16 commits into from
Jun 15, 2022

Conversation

aly76
Copy link
Contributor

@aly76 aly76 commented Jun 8, 2022

Description

  • Resolve dependencies for Build command, taking the last validated package version. For dependencies on packages from the same repo, the package versions are filtered to the branch.
  • A package version is considered to be from the same branch, if its associated git tag is reachable from HEAD.
  • Dynamic dependencies are respected. That is, dependencies on packages that are also a part of the same build, will be resolved to the version created by the build.
  • Artifact metadata and sfdx-project.json now reflect the resolved dependencies
  • Individual package creation commands no longer resolve dependencies

closes #496

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

aly76 added 6 commits June 3, 2022 11:46
Resolve package dependencies at the start of build and also dynamically, as
dependencies are built. Take last validated package version created from the
same branch, for packages from the same repo.

Save resolved dependencies in artifact metadata and sfdx-project.json
Do not resolve versions for quick build
@aly76 aly76 requested a review from azlam-abdulsalam June 8, 2022 05:03
@aly76 aly76 changed the base branch from main to develop June 8, 2022 05:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #1019 (e45cce5) into develop (bfc7940) will increase coverage by 1.42%.
The diff coverage is 84.26%.

@@             Coverage Diff             @@
##           develop    #1019      +/-   ##
===========================================
+ Coverage    58.13%   59.55%   +1.42%     
===========================================
  Files           51       52       +1     
  Lines         1598     1674      +76     
  Branches       340      357      +17     
===========================================
+ Hits           929      997      +68     
- Misses         626      634       +8     
  Partials        43       43              
Impacted Files Coverage Δ
packages/core/src/package/SfpPackageBuilder.ts 17.42% <12.50%> (+0.10%) ⬆️
packages/core/src/project/ProjectConfig.ts 76.74% <75.00%> (+0.55%) ⬆️
.../impl/parallelBuilder/PackageDependencyResolver.ts 94.20% <94.20%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc7940...e45cce5. Read the comment docs.

@azlam-abdulsalam
Copy link
Contributor

@aly76 can you also check whether deleted dependencies are not popped in during resolution
forcedotcom/cli#1514.

@azlam-abdulsalam azlam-abdulsalam merged commit e3ff2c6 into develop Jun 15, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the issue/496 branch June 15, 2022 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Dependencies might be used during build stage
3 participants