Fail creation of unlocked package when test coverage is below 75% (#457)

* Fix Incorrectly reported metrics * Fail Create unlocked Package command when the coverage is low * Change condition to isCoverageEnabled
dxatscale · Mar 22, 2021 · f24d321 · f24d321
1 parent c7bd65a
commit f24d321
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 27 deletions.
diff --git a/packages/core/src/sfpcommands/package/CreateUnlockedPackageImpl.ts b/packages/core/src/sfpcommands/package/CreateUnlockedPackageImpl.ts
@@ -90,8 +90,6 @@ export default class CreateUnlockedPackageImpl {
     if(packageTypeInfo==null)
     {
       SFPLogger.log("Unable to find a package info for this particular package, Are you sure you created this package?");
-      SFPLogger.log("Unable to find a package info for this particular package, Are you sure you created this package?");
-
     }
 
 
@@ -165,6 +163,13 @@ export default class CreateUnlockedPackageImpl {
     //Get the full details on the package
     await this.getPackageInfo();
 
+
+    //Break if coverage is low
+    if (this.isCoverageEnabled) {
+      if(!this.packageArtifactMetadata.has_passed_coverage_check)
+       throw new Error("This package has not meet the minimum coverage requirement of 75%");
+    }
+
     //Generate Source Artifact
     let mdapiPackageArtifactDir = SourcePackageGenerator.generateSourcePackageArtifact(
       this.project_directory,
@@ -333,7 +338,7 @@ export default class CreateUnlockedPackageImpl {
   }
 
   private buildExecCommand(): string {
-    let command = `npx sfdx force:package:version:create -p ${this.sfdx_package}  -w ${this.wait_time} --definitionfile ${this.config_file_path} --json`;
+    let command = `sfdx force:package:version:create -p ${this.sfdx_package}  -w ${this.wait_time} --definitionfile ${this.config_file_path} --json`;
 
     if (!isNullOrUndefined(this.version_number))
       command += `  --versionnumber ${this.version_number}`;

diff --git a/packages/sfpowerscripts-cli/src/BuildBase.ts b/packages/sfpowerscripts-cli/src/BuildBase.ts
@@ -90,6 +90,8 @@ export default abstract class BuildBase extends SfpowerscriptsCommand {
 
       let executionStartTime = Date.now();
 
+
+
       buildExecResult = await this.getBuildImplementer().exec();
 
       if (
@@ -137,7 +139,9 @@ export default abstract class BuildBase extends SfpowerscriptsCommand {
         tags["tag"] = this.flags.tag;
       }
 
-      console.log("Sending Metrics if enabled..", tags);
+      SFPStatsSender.logCount("build.scheduled", tags);
+
+
       SFPStatsSender.logGauge(
         "build.duration",
         Date.now() - executionStartTime,

diff --git a/packages/sfpowerscripts-cli/src/commands/sfpowerscripts/orchestrator/deploy.ts b/packages/sfpowerscripts-cli/src/commands/sfpowerscripts/orchestrator/deploy.ts
@@ -147,34 +147,23 @@ export default class Deploy extends SfpowerscriptsCommand {
       if (this.flags.logsgroupsymbol?.[1])
         console.log(this.flags.logsgroupsymbol[1]);
 
+     SFPStatsSender.logCount("deploy.scheduled",tags);   
+
       SFPStatsSender.logGauge(
         "deploy.duration",
         totalElapsedTime,
         tags
       );
-
-      SFPStatsSender.logCount(
-        "deploy.succeeded",
-        tags
-      );
-
-      SFPStatsSender.logGauge(
-        "deploy.succeeded.packages",
-        deploymentResult.deployed.length,
-        tags
-      );
-
-
-
       if (deploymentResult.failed.length > 0) {
         SFPStatsSender.logCount(
           "deploy.failed",
           tags
         );
-
-        SFPStatsSender.logGauge(
-          "deploy.failed.packages",
-          deploymentResult.failed.length,
+      }
+      else
+      {
+        SFPStatsSender.logCount(
+          "deploy.succeeded",
           tags
         );
       }

diff --git a/packages/sfpowerscripts-cli/src/impl/deploy/DeployImpl.ts b/packages/sfpowerscripts-cli/src/impl/deploy/DeployImpl.ts
@@ -120,7 +120,7 @@ export default class DeployImpl {
           this.checkIfPackagesPromoted(queue, packagesToPackageInfo);
       }
 
-      SFPStatsSender.logCount("deploy.scheduled",this.props.tags);
+
       SFPStatsSender.logGauge(
         "deploy.scheduled.packages",
         queue.length,

diff --git a/packages/sfpowerscripts-cli/src/impl/parallelBuilder/BuildImpl.ts b/packages/sfpowerscripts-cli/src/impl/parallelBuilder/BuildImpl.ts
@@ -87,10 +87,6 @@ export default class BuildImpl {
       this.props.projectDirectory
     );
 
-    SFPStatsSender.logCount("build.scheduled", {
-      isDiffCheckEnabled: this.props.isDiffCheckEnabled ? "true" : "false",
-      prMode: this.props.isBuildAllAsSourcePackages ? "true" : "false",
-    });
 
     //Do a diff Impl
     if (this.props.isDiffCheckEnabled) {