Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: remove_item_from_list/2 #57

Merged
merged 7 commits into from
Sep 14, 2023
Merged

PR: remove_item_from_list/2 #57

merged 7 commits into from
Sep 14, 2023

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Sep 14, 2023 •
edited
Loading

Working on this for: dwyl/mvp#422 which will in turn be used in: dwyl/mvp#420

@nelsonic nelsonic added enhancement New feature or request chore a tedious but necessary task often paying technical debt in-progress An issue or pull request that is being worked on by the assigned person T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Sep 14, 2023
@nelsonic nelsonic self-assigned this Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #57 (a2c5135) into main (370a032) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           45        46    +1     
=========================================
+ Hits            45        46    +1
Files Changed Coverage Δ
lib/useful.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nelsonic nelsonic mentioned this pull request Sep 14, 2023
Closed
1 task
@nelsonic nelsonic mentioned this pull request Sep 14, 2023
Closed
3 tasks
@nelsonic
Copy link
Member Author

Hi @LuchoTurtle, 👋
a quick PR to add a basic function (that should be in the standard library ... but isn't 🙄) #55
Used in: dwyl/mvp#422
Thanks.

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. and removed in-progress An issue or pull request that is being worked on by the assigned person T25m Time Estimate 25 Minutes labels Sep 14, 2023
@nelsonic nelsonic assigned LuchoTurtle and unassigned nelsonic Sep 14, 2023
nelsonic added a commit to dwyl/mvp that referenced this pull request Sep 14, 2023
@nelsonic
#422 bump Useful library to 1.13 for Useful.remove_item_from_list/2 r…
72dd787 
…ef: dwyl/useful#57
@nelsonic
Copy link
Member Author

Reversed the order of the arguments item, list becomes list, item so that it's pipeable. ref: #55 (comment)
No further changes required. Please merge. Thanks.

LuchoTurtle
LuchoTurtle approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@LuchoTurtle LuchoTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks! 🥳

@LuchoTurtle LuchoTurtle merged commit eefeb4f into main Sep 14, 2023
3 checks passed
@LuchoTurtle LuchoTurtle deleted the remove_item_from_list-#55 branch September 14, 2023 17:50
@LuchoTurtle
Copy link
Member

LuchoTurtle commented Sep 14, 2023 •
edited
Loading

@nelsonic are you publishing this or do you want me to?

@nelsonic
Copy link
Member Author

Published immediately. Thanks. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuchoTurtle LuchoTurtle LuchoTurtle approved these changes

Assignees

@LuchoTurtle LuchoTurtle

Labels
awaiting-review An issue or pull request that needs to be reviewed chore a tedious but necessary task often paying technical debt enhancement New feature or request T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @LuchoTurtle