Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Selected tags are covered by tag input dropdown #296

Closed
nelsonic opened this issue Feb 9, 2023 · 4 comments
Closed

BUG: Selected tags are covered by tag input dropdown #296

nelsonic opened this issue Feb 9, 2023 · 4 comments
Assignees
@nelsonic @seaneady
Labels
awaiting-review An issue or pull request that needs to be reviewed bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Feb 9, 2023

At present the selected tags in the MVP are covered by the tag selector:

image

This is a super lame UX bug that we can easily fix.

Full video illustrating the bug:
https://user-images.githubusercontent.com/194400/217787383-cee3e739-4a9b-45dc-9686-c1a73d5d38da.mov

Described in more detail in: #221 (comment)
@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment! technical A technical issue that requires understanding of the code, infrastructure or dependencies priority-1 Highest priority issue. This is costing us money every minute that passes. chore a tedious but necessary task often paying technical debt T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written elixir Pull requests that update Elixir code labels Feb 9, 2023
@nelsonic nelsonic self-assigned this Feb 9, 2023
@nelsonic nelsonic moved this to 🏗 In progress in dwyl app kanban Feb 9, 2023
@nelsonic
Copy link
Member Author

nelsonic commented Feb 9, 2023

Pairing on this now with @seaneady on Zoom. ⏳ 🧑‍💻

nelsonic added a commit that referenced this issue Feb 9, 2023
@nelsonic
move selected tags above tags selector #296
3208674
@nelsonic nelsonic mentioned this issue Feb 9, 2023
Merged
1 task
@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Feb 9, 2023
@nelsonic nelsonic moved this from 🏗 In progress to ⏳Awaiting Review in dwyl app kanban Feb 9, 2023
@nelsonic
Copy link
Member Author

nelsonic commented Feb 9, 2023

PR: #298

@nelsonic
Copy link
Member Author

nelsonic commented Feb 9, 2023

Review app working: https://mvp-pr-298.fly.dev/
image

nelsonic added a commit that referenced this issue Feb 9, 2023
@nelsonic
Merge branch 'main' into fix-tags-cover-issue-#296
3bfb1e0
seaneady added a commit that referenced this issue Feb 10, 2023
@seaneady
Merge pull request #298 from dwyl/fix-tags-cover-issue-#296
1988be0 
PR: move selected `tags` above `tags` selector #296
@nelsonic
Copy link
Member Author

Shipped to prod:

Image

@github-project-automation github-project-automation bot moved this from ⏳Awaiting Review to ✅ Done in dwyl app kanban Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

@seaneady seaneady

Labels
awaiting-review An issue or pull request that needs to be reviewed bug Suspected or confirmed bug (defect) in the code chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code help wanted If you can help make progress with this issue, please comment! priority-1 Highest priority issue. This is costing us money every minute that passes. T1h Time Estimate 1 Hour tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @seaneady