avoid modifying item.cid or list.cid when updating #418

lib/app/item.ex

@@ -38,9 +38,16 @@ defmodule App.Item do
     item
     |> cast(attrs, [:person_id, :status, :text])
     |> validate_required([:person_id])
-    |> App.Cid.put_cid()
   end
 
+  # Update an item without changing the cid ref: #418
+  def changeset_update(item, attrs) do
+    item
+    |> cast(attrs, [:cid, :person_id, :status, :text])
+    |> validate_required([:cid, :text, :person_id])
+  end
+
+
   @doc """
   `create_item/1` creates an `item`.
 
@@ -164,7 +171,7 @@ defmodule App.Item do
   """
   def update_item(%Item{} = item, attrs) do
     item
-    |> Item.changeset(attrs)
+    |> Item.changeset_update(attrs)
     |> PaperTrail.update(originator: %{id: Map.get(attrs, :person_id, 0)})
   end
 
@@ -186,7 +193,7 @@ defmodule App.Item do
 
   def delete_item(id) do
     get_item!(id)
-    |> Item.changeset(%{status: 6})
+    |> Item.changeset_update(%{status: 6})
     |> Repo.update()
   end
 

lib/app/list.ex

@@ -25,6 +25,13 @@ defmodule App.List do
     |> App.Cid.put_cid()
   end
 
+  # Update an list without changing the cid ref: #418
+  def changeset_update(list, attrs \\ %{}) do
+    list
+    |> cast(attrs, [:name, :person_id, :seq, :sort, :status])
+    |> validate_required([:cid, :name, :person_id])
+  end
+
   @doc """
   `create_list/1` creates an `list`.
 
@@ -68,7 +75,7 @@ defmodule App.List do
   """
   def delete_list(id) do
     get_list!(id)
-    |> changeset(%{status: 6})
+    |> changeset_update(%{status: 6})
     |> Repo.update()
   end
 
@@ -106,7 +113,7 @@ defmodule App.List do
   """
   def update_list(%List{} = list, attrs) do
     list
-    |> List.changeset(attrs)
+    |> List.changeset_update(attrs)
     |> PaperTrail.update()
   end