Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Learn Next Section issue #118 #119

Merged
merged 5 commits into from
Jan 2, 2019

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 1, 2019

  • Reduce "what should I learn next?" section to de-clutter and help readers focus.
  • Tidy up line length for maintainability.
  • Fixed a couple of typos.

@nelsonic nelsonic self-assigned this Jan 1, 2019
@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #119   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          33     33           
=====================================
  Hits           33     33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce2fd6...d32d39a. Read the comment docs.

@nelsonic
Copy link
Member Author

nelsonic commented Jan 1, 2019

@iteles when you get a chance, please review & merge. Thanks! 👍

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Agree that daydream and nightmare are not something to point people to directly from here as they aren't that great at the moment but something like Cypress might also be good to have in the Next section if we feel we can recommend it at a later stage.

Thanks for the updates!

@iteles iteles merged commit 4d6ee6f into master Jan 2, 2019
@iteles iteles deleted the reduce-learn-next-section-issue#118 branch January 2, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants