Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #395

Closed
5 of 9 tasks
ghost opened this issue Sep 29, 2017 · 8 comments
Closed
5 of 9 tasks

Update README #395

ghost opened this issue Sep 29, 2017 · 8 comments
Labels
priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T30min
Milestone

Comments

@ghost
Copy link

ghost commented Sep 29, 2017

  • General info about site (What it's for, why we have it, etc)
  • Who made it and who's responsible for what (e.g. Harry for design - link for invision, asset location)
  • Technologies used + how js should be used
  • How the submission and sign-up forms work
  • Conventions (e.g. branding, capitalisation and links)
  • How and why it's hosted
  • How to clone repo, set up live server and view locally
  • How to add yourself as a new team member
  • How to add a blog post

(Feel free to expand on and/or reorder these points as you see fit)

@ghost ghost added the priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished label Sep 29, 2017
@ghost ghost added this to the Sprint 3 milestone Sep 29, 2017
@finnhodgkin
Copy link
Contributor

By 'link for invision and assets', do you mean a publicly accessibly link to the invision designs and assets, because I'm not sure that's possible. I might be wrong though, I've hardly used Invision 😕.

I could save out the designs and host them somewhere if we want them publicly available.

@ghost
Copy link
Author

ghost commented Oct 4, 2017

@finnhodgkin I just mean a link to the designs - I presume if someone doesn't have access it will come up with a splash that says 'you don't have access, please request' so it will then email those who do, which is good enough (maybe?)

@finnhodgkin
Copy link
Contributor

Found a public share link: https://projects.invisionapp.com/share/VSBOA5D8B

@ZooeyMiller ZooeyMiller self-assigned this Oct 5, 2017
@ZooeyMiller ZooeyMiller added in-progress An issue or pull request that is being worked on by the assigned person T4h Time Estimate 4 Hours labels Oct 5, 2017
@ZooeyMiller
Copy link
Contributor

ZooeyMiller commented Oct 5, 2017

I'm hesitant to add the information of how to run the site locally with live-server, because strictly speaking it doesn't work. Unless we were happy to change all links on the site to include .html on the end, it just won't work on live-server.

I know you can manually go to each page, or change the url to include .html, but I don't think that's a reasonable thing to have in our README.

@ZooeyMiller
Copy link
Contributor

I'm happy to add information on how it's hosted, but unclear on "why it's hosted" in this way?

@finnhodgkin finnhodgkin self-assigned this Oct 5, 2017
finnhodgkin added a commit that referenced this issue Oct 5, 2017
finnhodgkin added a commit that referenced this issue Oct 5, 2017
finnhodgkin added a commit that referenced this issue Oct 5, 2017
finnhodgkin added a commit that referenced this issue Oct 5, 2017
@ZooeyMiller ZooeyMiller removed the in-progress An issue or pull request that is being worked on by the assigned person label Oct 6, 2017
@ghost
Copy link
Author

ghost commented Oct 9, 2017

@ZooeyMiller in response to #395 (comment)

Do we have a better solution for viewing the site other than live-server + adding .html in the view or permanently changing all the links to .html in the code?

in response to #395 (comment)
We just need a line explaining why - as in it's currently hosted on GitHub Pages as an interim solution as the plan is for the site to use a phpenix server, which has yet to be built. We've used GitHub pages because it integrates with GitHub well and it's free. The cons of GitHub pages are that it doesn't allow https with custom domains, so we have used a workaround...etc

@ghost ghost assigned ZooeyMiller Oct 9, 2017
@ZooeyMiller
Copy link
Contributor

ZooeyMiller commented Oct 9, 2017

@iteles asked that we ask you to do the remaining updates to the readme, just so we don't duplicate work by us asking you questions, you commenting answers, then us putting them in the README.

In terms of the running locally, there are no better solutions than live-server and adding .html to the links that I immediately know of. The proper solution would be writing a server.

@ZooeyMiller ZooeyMiller assigned ghost and unassigned ZooeyMiller Oct 9, 2017
@ghost ghost added the T30min label Oct 9, 2017
@ghost ghost removed the T4h Time Estimate 4 Hours label Oct 9, 2017
@jammur jammur unassigned ghost Dec 14, 2017
@nelsonic
Copy link
Member

Agree that we will need to update the README.md when the new site #493 is launched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T30min
Projects
None yet
Development

No branches or pull requests

3 participants