-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LinearAncillaComposite #530
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 89.65% 86.57% -3.09%
==========================================
Files 24 25 +1
Lines 1760 1832 +72
==========================================
+ Hits 1578 1586 +8
- Misses 182 246 +64 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be very useful, @pau557. I made a few comments inline.
Needs to be added to docs here: https://github.com/dwavesystems/dwave-system/blob/master/docs/reference/composites.rst
releasenotes/notes/add-linear-ancilla-composite-3281ed6733b0f0c7.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Any more comments or ready to merge? |
I had missed many comments, apologies @JoelPasvolsky. I think everything is addressed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments.
This composite does not suport the auto_scale parameter. BQM Scaling | ||
can be done with :class:`~dimod.ScaleComposite`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This composite does not suport the auto_scale parameter. BQM Scaling | |
can be done with :class:`~dimod.ScaleComposite`. | |
This composite does not support the :ref:`param_autoscale` parameter; use the | |
:class:`~dwave.preprocessing.composites.ScaleComposite` for scaling. |
can be done with :class:`~dimod.ScaleComposite`. | ||
|
||
Args: | ||
bqm (:obj:`~dimod.BinaryQuadraticModel`): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bqm (:obj:`~dimod.BinaryQuadraticModel`): | |
bqm (:class:`~dimod.binary.BinaryQuadraticModel`): |
Args: | ||
child_sampler (:class:`dimod.Sampler`): | ||
A dimod sampler, such as a :class:`~dwave.system.samplers.DWaveSampler()`, | ||
that has flux bias controls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a small code example, ideally using the EmbeddingComposite or such. See example in TilingComposite for the format and preferred size.
In scenarios where the h biases are not available or sufficient in range, one can use auxiliary qubits polarized with a large flux bias and coupled to the data qubit. This method:
This PR adds a LinearAncillaComposite that implements this technique.
For the reviewers, please take into account future extensions of this method:
Please educate me on how to use the correct Sphynx syntax