Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace inr/natreg config placeholders #497

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: replace inr/natreg config placeholders #497

merged 2 commits into from
Dec 4, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Dec 4, 2024

Description

Replace inr url placeholders

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble marked this pull request as ready for review December 4, 2024 07:35
@fibble fibble requested review from ilindsay and a team as code owners December 4, 2024 07:35
sdh100shaun
sdh100shaun previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@sdh100shaun sdh100shaun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix security error obvs then lgtm

@fibble fibble requested a review from sdh100shaun December 4, 2024 09:28
@ilindsay ilindsay merged commit 2b7d1a6 into main Dec 4, 2024
20 of 21 checks passed
@ilindsay ilindsay deleted the replace-inr-config-placeholders-for-urls branch December 4, 2024 12:22
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
ilindsay pushed a commit that referenced this pull request Dec 4, 2024
@fibble @ilindsay
fix: replace inr/natreg config placeholders (#497)
1fabaa8 
* fix: replace inr/natreg config placeholders

* fix: replace inr/natreg config placeholders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@culshawn culshawn culshawn approved these changes

@ilindsay ilindsay ilindsay approved these changes

@sdh100shaun sdh100shaun Awaiting requested review from sdh100shaun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fibble @sdh100shaun @ilindsay @culshawn