Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5809 batch alarms topic policy #392

Merged
merged 12 commits into from
Oct 17, 2024
Merged

fix: 5809 batch alarms topic policy #392

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5ce823e
fix: batch rule names
Wi11Shell Oct 8, 2024
31e8167
docs: update Terraform docs
github-actions[bot] Oct 8, 2024
5965d17
fix: add name to targets
Wi11Shell Oct 9, 2024
a17511c
docs: update Terraform docs
github-actions[bot] Oct 9, 2024
8a9b854
fix: more event renaming
Wi11Shell Oct 9, 2024
5924924
fix: used dlq module
Wi11Shell Oct 14, 2024
d337dba
fix: updated queue arn
Wi11Shell Oct 14, 2024
00edcc1
docs: update Terraform docs
github-actions[bot] Oct 14, 2024
5eddb63
fix: sqs module version
Wi11Shell Oct 14, 2024
7d71451
fix: eventbridge permissions
Wi11Shell Oct 15, 2024
6bdebbb
fix: batch failure rule conditions
Wi11Shell Oct 17, 2024
7812955
docs: update Terraform docs
github-actions[bot] Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions infra/terraform/modules/service/batch.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ module "sns_batch_failure" {

sub = {
actions = [
"sns:Publish",
"sns:Subscribe",
"sns:Receive",
]
Expand All @@ -230,12 +231,6 @@ module "sns_batch_failure" {
type = "Service"
identifiers = ["events.amazonaws.com"]
}]

conditions = [{
test = "ArnLike"
variable = "aws:SourceArn"
values = [module.eventbridge_sns.eventbridge_bus_arn]
}]
}
}

Expand All @@ -257,7 +252,7 @@ module "sqs_deadletter" {
version = "~> 4.2.1"
source = "terraform-aws-modules/sqs/aws"

name = "vol-app-${var.environment}-batch-failure-dlq"
name = "vol-app-${var.environment}-batch-failure-queue"

create_dlq = true
redrive_policy = {
Expand Down