-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
5809 batch alarms remove email subscription (#395)
* fix: batch rule names * docs: update Terraform docs * fix: add name to targets * docs: update Terraform docs * fix: more event renaming * fix: used dlq module * fix: updated queue arn * docs: update Terraform docs * fix: sqs module version * fix: remove email subscription and dlq * docs: update Terraform docs --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
4404b29
commit e82613e
Showing
2 changed files
with
5 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -190,9 +190,8 @@ module "eventbridge_sns" { | |
targets = { | ||
"vol-app-${var.environment}-batch-failure-event" = [ | ||
{ | ||
name = "batch-fail-event" | ||
arn = module.sns_batch_failure.topic_arn | ||
dead_letter_arn = module.sqs_deadletter.queue_arn | ||
name = "batch-fail-event" | ||
arn = module.sns_batch_failure.topic_arn | ||
} | ||
] | ||
} | ||
|
@@ -233,13 +232,13 @@ module "sns_batch_failure" { | |
}] | ||
} | ||
} | ||
|
||
/* | ||
subscriptions = { | ||
"vol-app-${var.environment}-batch-failure-email" = { | ||
protocol = "email" | ||
endpoint = "[email protected]" | ||
endpoint = "" | ||
} | ||
} | ||
*/ | ||
|
||
tags = { | ||
"Name" = "vol-app-${var.environment}-aws-sns-batch-failure" | ||
|
@@ -248,19 +247,6 @@ module "sns_batch_failure" { | |
|
||
} | ||
|
||
module "sqs_deadletter" { | ||
version = "~> 4.2.1" | ||
source = "terraform-aws-modules/sqs/aws" | ||
|
||
name = "vol-app-${var.environment}-batch-failure-queue" | ||
|
||
create_dlq = true | ||
redrive_policy = { | ||
# default is 5 for this module | ||
maxReceiveCount = 10 | ||
} | ||
} | ||
|
||
resource "aws_cloudwatch_log_group" "this" { | ||
name = "/aws/batch/vol-app-${var.environment}" | ||
retention_in_days = 1 | ||
|