This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json # composer.lock
JoshuaLicense
suggested changes
Jan 2, 2024
ilindsay
reviewed
Jan 2, 2024
JoshuaLicense
suggested changes
Jan 3, 2024
JoshuaLicense
suggested changes
Jan 3, 2024
JoshuaLicense
approved these changes
Jan 4, 2024
ilindsay
approved these changes
Jan 5, 2024
jerotire
pushed a commit
to dvsa/vol-app
that referenced
this pull request
Aug 16, 2024
* chore(deps): remove Nexus dependencies * chore(deps): Remove dependency on olcs-laminas * chore(deps): Remove dependency on olcs/olcs-devtools * chore(ci-cd): add CI/CD workflow * chore(config): add configuration files for maintaining code consistency and quality * chore: moved phpUnit config to root directory * chore(deps): added dev dependencies packages * chore(deps): update PSR-4 autoloading configuration * chore(tests): update namespace in test files * chore(tests): missing testHelpers Trait file added * chore: updated .gitignore * chore(test): updated namespaces in the test file * Feat: missing Abstract file added and namespacing added accordingly * Feat: Added missing namespace * Feat: BootStrap reliance removed * Feat: TestHelper Class added * Feat: BootStrap reliance removed * Feat: Missing serviceManager method added * Feat: Setting up Logger initially * Feat: Code standard correct path added * chore(deps): updated dependencies * chore(deps): added new dependencies * chore(deps): update olcs/common to ^4.206.516 * chore: removed lock files * chore(deps): updated packages for composer to pick appropriate version * chore: updated .gitignore * chore(deps): added, removed and updated packages as required and need accordingly * chore(deps): added, removed and updated packages as required and needed accordingly * chore(deps): added, removed and updated packages as required and needed accordingly * chore: Removed debugging flagged to stop on error * chore: Removed in favor of default setting * chore(deps): added, removed and updated packages as required and needed accordingly * chore: project specific workflow added * chore: added correct path of phpstan and psalm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
olcs-laminas
,olcs-devtools
&olcs-testhelpers
libraries.Bootstrap.php
along with refactoringNotable commit breakdown
0f12183 Remove
Bootstrap.php
The bootstrap file was used as helper functions. This isn't the intended use-case of a bootstrap file. This aligns with the refactors in other repositories.
5373ed7 Nexus dependencies removed
composer.json
73d2b33 added
cd.yaml
&ci.yaml
workflowAdded CI workflows (unit tests, static analysis, & security). Unit tests to pass as a minimum
5a31b1b added
.editorconfig
,phpcs.xml.dist
,phpstan.neon.dist
,phpunit.xml.dist
&psalm.xml.dist
Add editorconfig, PHPUnit, Psalm, PHPStan, PHPCS configuration files (via. vendor-bin). Move PHPUnit config to root directory.
Related issue: JIRA_TICKET_NUMBER
Before submitting (or marking as "ready for review")